[PATCH] D54312: [CSP, Cloning] Update DuplicateInstructionsInSplitBetween to use DomTreeUpdater.

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 13 08:33:29 PST 2018


kuhar added inline comments.


================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:444
+// Check if any of the arguments in CS are predicated on a PHI node and return
+// the set of predecessors we should use for splitting
+static PredsWithCondsTy shouldSplitOnPHIPredicatedArgument(CallSite CS) {
----------------
nit: missing dot at the end of the comment


================
Comment at: unittests/Transforms/Utils/CloningTest.cpp:228
 
+  // Dummy DTU
   ValueToValueMapTy Mapping;
----------------
nit: missing dot at the end of the comment


================
Comment at: unittests/Transforms/Utils/CloningTest.cpp:277
 
+  // Dummy DTU
+  DomTreeUpdater DTU(DomTreeUpdater::UpdateStrategy::Lazy);
----------------
nit: missing dot at the end of the comment


================
Comment at: unittests/Transforms/Utils/CloningTest.cpp:330
 
+  // Dummy DTU
+  DomTreeUpdater DTU(DomTreeUpdater::UpdateStrategy::Lazy);
----------------
nit: missing dot at the end of the comment


https://reviews.llvm.org/D54312





More information about the llvm-commits mailing list