[PATCH] D54008: [X86] Fix MCNullStreamer support for modules with a CodeView flag

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 13 07:01:05 PST 2018


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86AsmPrinter.cpp:92
     X86TargetStreamer *XTS =
         static_cast<X86TargetStreamer *>(OutStreamer->getTargetStreamer());
     unsigned ParamsSize =
----------------
(style) We normally do auto for cast cases like this as the type is obvious.


================
Comment at: lib/Target/X86/X86AsmPrinter.cpp:104
+    if (X86TargetStreamer *XTS =
+            static_cast<X86TargetStreamer *>(OutStreamer->getTargetStreamer()))
+      XTS->emitFPOEndProc();
----------------
(style) We normally do auto for cast cases like this as the type is obvious.


Repository:
  rL LLVM

https://reviews.llvm.org/D54008





More information about the llvm-commits mailing list