[PATCH] D54346: [SelectionDAG][X86] Relax restriction on the width of an input to *_EXTEND_VECTOR_INREG. Use them and regular *_EXTEND to replace the X86 specific VSEXT/VZEXT opcodes

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 13 05:57:25 PST 2018


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:40087
     SmallVector<APInt, 4> Vals(NumElts, APInt(EltSizeInBits, 0));
-    bool IsZEXT =
-        (Opcode == X86ISD::VZEXT) || (Opcode == ISD::ZERO_EXTEND_VECTOR_INREG);
----------------
craig.topper wrote:
> I just flipped this in case we ever wanted to send ANY_EXTEND_VECTOR_INREG in here.
Do this as a separate pre-commit? Not sure if its worth it or not - but seems only tangentially related. 


https://reviews.llvm.org/D54346





More information about the llvm-commits mailing list