[PATCH] D54244: [HotColdSplitting] Refine definition of unlikelyExecuted

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya accepted this revision.
hiraditya added a comment.
This revision is now accepted and ready to land.

Thanks for removing the exception handlers. I never wanted to hard code them in the first place.

> It’s not clear that there’s an actual benefit to outlining it. A call to exit(0) could be expected to happen: outlining it to a cold section might force a page fault when it otherwise wouldn’t.

Agreed, also long jumps may incur page faults early in the program. Outlining them may have additional page faults.  A program using co-routine features may see unexpected perf changes if we outline long jumps.


https://reviews.llvm.org/D54244