[PATCH] D54314: [ELF] - Fix R_AARCH64_ADR_GOT_PAGE, R_AARCH64_LD64_GOT_LO12 handling against IFUNC symbols.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 13 02:46:17 PST 2018


grimar added a comment.

In https://reviews.llvm.org/D54314#1296721, @peter.smith wrote:

> I've tested the patch against the original C++ example in https://reviews.llvm.org/D54145 and that works ok. I get a segfault when I remove -fPIC though. It does work correctly when I compile with clang but link with ld.bfd (From binutils 2.25).
>
> I'll track down the segfault and will report back as soon as I can. With luck we are just missing something out rather than there being a problem. I think what we have here is a definite improvement though so we could do further work in a follow up patch.


I guess the segfault you are talking about is the same I mentioned here: https://reviews.llvm.org/D54145#1291558.
It reproduced without any of my patched, so seems to be a different issue to fix for AArch64.


https://reviews.llvm.org/D54314





More information about the llvm-commits mailing list