[PATCH] D54348: Permit multiple .file directives with -g

Brian Cain via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 12 15:32:09 PST 2018


bcain added a comment.

In https://reviews.llvm.org/D54348#1295895, @dblaikie wrote:

>


...

> So probably need to have some discussion about when/where/if this should fire.

I'm less concerned about "file number already allocated" than I am about the approach in general.  Since I bypassed Paul's suggestion, does this design really represent the right approach?  Are the expected results in "CHECK-DEBUG/CHECK-DEBUG-ASM" correct?  Should the test case plumb deeper to look for how the label's src location is stored?


Repository:
  rL LLVM

https://reviews.llvm.org/D54348





More information about the llvm-commits mailing list