[PATCH] D54327: Adding debug info to support Fortran (part 3)

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 12 15:27:22 PST 2018


dblaikie added inline comments.


================
Comment at: include/llvm/IR/DebugInfoMetadata.h:2619
+                Ops), LineNo(LineNo), AlignInBits(AlignInBits) {}
+  ~DICommonBlock() = default;
+
----------------
Probably skip this as it's the implicit default?

(I see this seems to have been defaulted all over the Metadata hierarchy - so far as I can tell, still unnecessary in all those places & no need to propagate this around further?)


Repository:
  rL LLVM

https://reviews.llvm.org/D54327





More information about the llvm-commits mailing list