[PATCH] D54448: [FileSystem] Add expand_tilde function

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 12 14:41:12 PST 2018


zturner added inline comments.


================
Comment at: llvm/unittests/Support/Path.cpp:532-534
+  ASSERT_NO_ERROR(
+      fs::create_directories(Twine(TestDirectory) + "/test1/test2/test3"));
+  ASSERT_TRUE(fs::exists(Twine(TestDirectory) + "/test1/test2/test3"));
----------------
I don't think we need these lines?


================
Comment at: llvm/unittests/Support/Path.cpp:548
+
+  ASSERT_NO_ERROR(fs::remove_directories(Twine(TestDirectory) + "/test1"));
+}
----------------
Or this line?


https://reviews.llvm.org/D54448





More information about the llvm-commits mailing list