[PATCH] D54301: [AMDGPU] Derive GCNSubtarget from MF to get overridden target features

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 12 12:59:33 PST 2018


scott.linder added a reviewer: kzhuravl.
scott.linder added a comment.

I don't quite understand what distinguishes the two versions of MCSubtargetInfo (getSTI() vs STM), but it appears a patch from Konstantin earlier this year changed this specific instance from `STM.getFeatureBits()` to `getSTI()`. Changing this back LGTM but I don't know what the rationale was in the first place, if it wasn't a typo, so I don't want to sign off without asking.


Repository:
  rL LLVM

https://reviews.llvm.org/D54301





More information about the llvm-commits mailing list