[PATCH] D54418: [llvm-exegesis] InstructionBenchmarkClustering::dbScan(): replace SetVector with custom BitVectorVector

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 12 12:58:54 PST 2018


MaskRay added a comment.

In https://reviews.llvm.org/D54418#1295942, @lebedev.ri wrote:

> In https://reviews.llvm.org/D54418#1295941, @MaskRay wrote:
>
> > I'm also not following...
>
>
> I'm sorry that i'm not following what you do not follow :)
>
> > DBSCAN is a BFS/Dijkstra-like algorithm. a `BitVector` + reserved `std::vector` suffice.
>
> Which is exactly what this `BitVectorVector` implements, as far as i can tell.
>  I do not understand what the question is. I'm sorry. Can you reformulate the question, please?


Maybe I should quote "talk is cheap" here... My idea is https://reviews.llvm.org/D54442 (I hope it won't interfere your other improvement)


Repository:
  rL LLVM

https://reviews.llvm.org/D54418





More information about the llvm-commits mailing list