[PATCH] D54439: CMake: Make most target symbols hidden by default

Mon Nov 12 12:07:26 PST 2018

tstellar created this revision.
tstellar added reviewers: chandlerc, beanz, mgorny.
Herald added subscribers: jsji, kristina, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, mgrang, edward-jones, zzheng, jrtc27, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar, asb, fedor.sergeev, kbarton, aheejin, jgravelle-google, sbc100, javed.absar, nhaehnle, jvesely, nemanjai, sdardis, dylanmckay, jyknight, dschuff, arsenm, jholewinski.

For builds with LLVM_BUILD_LLVM_DYLIB=ON and BUILD_SHARED_LIBS=OFF
this change makes all symbols in the target specific libraries hidden
by default.

A new macro called LLVM_EXPORT has been added to mark symbols in these
libraries public, which is mainly needed for the definitions of the
LLVMInitialize* functions.

This patch reduces the number of public symbols in libLLVM.so by about
25%.  This should improve load times for the dynamic library and also
make abi checker tools, like abidiff require less memory when analyzing
libLLVM.so

One side-effect of this change is that for builds with
LLVM_BUILD_LLVM_DYLIB=ON and LLVM_LINK_LLVM_DYLIB=ON some unittests that
access symbols that are no longer public will need to be statically linked.

Before and after public symbol counts (using gcc 8.2.1):
nm libLLVM-8svn.so.old | grep ' [A-Zuvw] ' | wc -l
34736
nm libLLVM-8svn.so.new | grep ' [A-Zuvw] ' | wc -l
25191

Repository:
  rL LLVM

https://reviews.llvm.org/D54439

Files:
  include/llvm/Support/Compiler.h
  lib/Target/AArch64/AArch64AsmPrinter.cpp
  lib/Target/AArch64/AArch64TargetMachine.cpp
  lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
  lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
  lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp
  lib/Target/AArch64/TargetInfo/AArch64TargetInfo.cpp
  lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
  lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
  lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
  lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCTargetDesc.cpp
  lib/Target/AMDGPU/TargetInfo/AMDGPUTargetInfo.cpp
  lib/Target/ARC/ARCAsmPrinter.cpp
  lib/Target/ARC/ARCTargetMachine.cpp
  lib/Target/ARC/Disassembler/ARCDisassembler.cpp
  lib/Target/ARC/MCTargetDesc/ARCMCTargetDesc.cpp
  lib/Target/ARC/TargetInfo/ARCTargetInfo.cpp
  lib/Target/ARM/ARMAsmPrinter.cpp
  lib/Target/ARM/ARMTargetMachine.cpp
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  lib/Target/ARM/Disassembler/ARMDisassembler.cpp
  lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp
  lib/Target/ARM/TargetInfo/ARMTargetInfo.cpp
  lib/Target/AVR/AVRAsmPrinter.cpp
  lib/Target/AVR/AVRTargetMachine.cpp
  lib/Target/AVR/AsmParser/AVRAsmParser.cpp
  lib/Target/AVR/Disassembler/AVRDisassembler.cpp
  lib/Target/AVR/MCTargetDesc/AVRMCTargetDesc.cpp
  lib/Target/AVR/TargetInfo/AVRTargetInfo.cpp
  lib/Target/BPF/AsmParser/BPFAsmParser.cpp
  lib/Target/BPF/BPFAsmPrinter.cpp
  lib/Target/BPF/BPFTargetMachine.cpp
  lib/Target/BPF/Disassembler/BPFDisassembler.cpp
  lib/Target/BPF/MCTargetDesc/BPFMCTargetDesc.cpp
  lib/Target/BPF/TargetInfo/BPFTargetInfo.cpp
  lib/Target/CMakeLists.txt
  lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp
  lib/Target/Hexagon/Disassembler/HexagonDisassembler.cpp
  lib/Target/Hexagon/HexagonAsmPrinter.cpp
  lib/Target/Hexagon/HexagonTargetMachine.cpp
  lib/Target/Hexagon/MCTargetDesc/HexagonMCTargetDesc.cpp
  lib/Target/Hexagon/TargetInfo/HexagonTargetInfo.cpp
  lib/Target/Lanai/AsmParser/LanaiAsmParser.cpp
  lib/Target/Lanai/Disassembler/LanaiDisassembler.cpp
  lib/Target/Lanai/LanaiAsmPrinter.cpp
  lib/Target/Lanai/LanaiTargetMachine.cpp
  lib/Target/Lanai/MCTargetDesc/LanaiMCTargetDesc.cpp
  lib/Target/Lanai/TargetInfo/LanaiTargetInfo.cpp
  lib/Target/MSP430/MCTargetDesc/MSP430MCTargetDesc.cpp
  lib/Target/MSP430/MSP430AsmPrinter.cpp
  lib/Target/MSP430/MSP430TargetMachine.cpp
  lib/Target/MSP430/TargetInfo/MSP430TargetInfo.cpp
  lib/Target/Mips/AsmParser/MipsAsmParser.cpp
  lib/Target/Mips/Disassembler/MipsDisassembler.cpp
  lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.cpp
  lib/Target/Mips/MipsAsmPrinter.cpp
  lib/Target/Mips/MipsTargetMachine.cpp
  lib/Target/Mips/TargetInfo/MipsTargetInfo.cpp
  lib/Target/NVPTX/MCTargetDesc/NVPTXMCTargetDesc.cpp
  lib/Target/NVPTX/NVPTXAsmPrinter.cpp
  lib/Target/NVPTX/NVPTXTargetMachine.cpp
  lib/Target/NVPTX/TargetInfo/NVPTXTargetInfo.cpp
  lib/Target/Nios2/MCTargetDesc/Nios2MCTargetDesc.cpp
  lib/Target/Nios2/Nios2AsmPrinter.cpp
  lib/Target/Nios2/Nios2TargetMachine.cpp
  lib/Target/Nios2/TargetInfo/Nios2TargetInfo.cpp
  lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp
  lib/Target/PowerPC/Disassembler/PPCDisassembler.cpp
  lib/Target/PowerPC/MCTargetDesc/PPCMCTargetDesc.cpp
  lib/Target/PowerPC/PPCAsmPrinter.cpp
  lib/Target/PowerPC/PPCTargetMachine.cpp
  lib/Target/PowerPC/TargetInfo/PowerPCTargetInfo.cpp
  lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
  lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp
  lib/Target/RISCV/MCTargetDesc/RISCVMCTargetDesc.cpp
  lib/Target/RISCV/RISCVAsmPrinter.cpp
  lib/Target/RISCV/RISCVTargetMachine.cpp
  lib/Target/RISCV/TargetInfo/RISCVTargetInfo.cpp
  lib/Target/Sparc/AsmParser/SparcAsmParser.cpp
  lib/Target/Sparc/Disassembler/SparcDisassembler.cpp
  lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp
  lib/Target/Sparc/SparcAsmPrinter.cpp
  lib/Target/Sparc/SparcTargetMachine.cpp
  lib/Target/Sparc/TargetInfo/SparcTargetInfo.cpp
  lib/Target/SystemZ/AsmParser/SystemZAsmParser.cpp
  lib/Target/SystemZ/Disassembler/SystemZDisassembler.cpp
  lib/Target/SystemZ/MCTargetDesc/SystemZMCTargetDesc.cpp
  lib/Target/SystemZ/SystemZAsmPrinter.cpp
  lib/Target/SystemZ/SystemZTargetMachine.cpp
  lib/Target/SystemZ/TargetInfo/SystemZTargetInfo.cpp
  lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
  lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp
  lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.cpp
  lib/Target/WebAssembly/TargetInfo/WebAssemblyTargetInfo.cpp
  lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
  lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
  lib/Target/X86/AsmParser/X86AsmParser.cpp
  lib/Target/X86/Disassembler/X86Disassembler.cpp
  lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp
  lib/Target/X86/TargetInfo/X86TargetInfo.cpp
  lib/Target/X86/X86AsmPrinter.cpp
  lib/Target/X86/X86TargetMachine.cpp
  lib/Target/XCore/Disassembler/XCoreDisassembler.cpp
  lib/Target/XCore/MCTargetDesc/XCoreMCTargetDesc.cpp
  lib/Target/XCore/TargetInfo/XCoreTargetInfo.cpp
  lib/Target/XCore/XCoreAsmPrinter.cpp
  lib/Target/XCore/XCoreTargetMachine.cpp
  unittests/CMakeLists.txt
  unittests/Target/AArch64/CMakeLists.txt
  unittests/Target/WebAssembly/CMakeLists.txt
  unittests/tools/llvm-exegesis/AArch64/CMakeLists.txt
  unittests/tools/llvm-exegesis/ARM/CMakeLists.txt
  unittests/tools/llvm-exegesis/PowerPC/CMakeLists.txt
  unittests/tools/llvm-exegesis/X86/CMakeLists.txt
  utils/unittest/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54439.173728.patch
Type: text/x-patch
Size: 63664 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181112/52a800cd/attachment-0001.bin>