[llvm] r346670 - [CostModel][X86] Add some initial cost tests for funnel shifts

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 12 09:07:02 PST 2018


On Mon, Nov 12, 2018 at 7:42 PM Simon Pilgrim via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
> Author: rksimon
> Date: Mon Nov 12 08:39:41 2018
> New Revision: 346670
>
> URL: http://llvm.org/viewvc/llvm-project?rev=346670&view=rev
> Log:
> [CostModel][X86] Add some initial cost tests for funnel shifts
>
> Still need to add full uniform/constant coverage but this is enough to check basic fshl/fshr cost handling
>
> Added:
>     llvm/trunk/test/Analysis/CostModel/X86/fshl.ll
>     llvm/trunk/test/Analysis/CostModel/X86/fshr.ll
>
> Added: llvm/trunk/test/Analysis/CostModel/X86/fshl.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/CostModel/X86/fshl.ll?rev=346670&view=auto
> ==============================================================================
> --- llvm/trunk/test/Analysis/CostModel/X86/fshl.ll (added)
> +++ llvm/trunk/test/Analysis/CostModel/X86/fshl.ll Mon Nov 12 08:39:41 2018
> @@ -0,0 +1,390 @@
> +; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py
> +; RUN: opt < %s -cost-model -analyze -mtriple=x86_64-apple-macosx10.8.0 -mattr=+ssse3 | FileCheck %s --check-prefixes=CHECK,SSE,SSSE3
> +; RUN: opt < %s -cost-model -analyze -mtriple=x86_64-apple-macosx10.8.0 -mattr=+sse4.2 | FileCheck %s --check-prefixes=CHECK,SSE,SSE42
> +; RUN: opt < %s -cost-model -analyze -mtriple=x86_64-apple-macosx10.8.0 -mattr=+avx | FileCheck %s --check-prefixes=CHECK,AVX,AVX1
> +; RUN: opt < %s -cost-model -analyze -mtriple=x86_64-apple-macosx10.8.0 -mattr=+avx2 | FileCheck %s --check-prefixes=CHECK,AVX,AVX2
> +; RUN: opt < %s -cost-model -analyze -mtriple=x86_64-apple-macosx10.8.0 -mattr=+avx512f | FileCheck %s --check-prefixes=CHECK,AVX512,AVX512F
> +; RUN: opt < %s -cost-model -analyze -mtriple=x86_64-apple-macosx10.8.0 -mattr=+avx512f,+avx512bw | FileCheck %s --check-prefixes=CHECK,AVX512,AVX512BW
> +; RUN: opt < %s -cost-model -analyze -mtriple=x86_64-apple-macosx10.8.0 -mattr=+avx512f,+avx512dq | FileCheck %s --check-prefixes=CHECK,AVX512,AVX512DQ
> +;
> +; RUN: opt < %s -cost-model -analyze -mtriple=x86_64-apple-macosx10.8.0 -mcpu=slm | FileCheck %s --check-prefixes=SLM
> +; RUN: opt < %s -cost-model -analyze -mtriple=x86_64-apple-macosx10.8.0 -mcpu=goldmont | FileCheck %s --check-prefixes=GLM

> +; RUN: opt < %s -cost-model -analyze -mtriple=x86_64-apple-macosx10.8.0 -mcpu=bdver2 | FileCheck %s --check-prefixes=BDVER2
Note that i intentionally *not* added bdver2 into existing costmodel tests.
I wasn't sure it gives any additional test coverage, especially since
bdver2 is not marked as CompleteModel,
(FIXME: when i do, nothing seems to break. is the check for sched
model completeness just bad?),
and D46276 is not there yet.

Should bdver2 be checked in test/Analysis/CostModel/X86/* ?

Roman.

> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list