[PATCH] D54096: [WebAssembly] Add support for the event section

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 12 08:47:15 PST 2018


aardappel added inline comments.


================
Comment at: include/llvm/MC/MCSymbolWasm.h:74
   }
+  void setEventType(wasm::WasmEventType ET) { EventType = ET; }
 };
----------------
aheejin wrote:
> @aardappel I changed the types of `GlobalType` and `EventType` to `llvm::Optional` and now we can remove those `GlobalTypeSet` and `EventTypeSet`. Thanks for the suggestion.
awesome.. that's a solution I hadn't thought of.


Repository:
  rL LLVM

https://reviews.llvm.org/D54096





More information about the llvm-commits mailing list