[PATCH] D54422: [ELF] - Do not ICF two sections with different output sections when using linker scripts

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 12 05:18:02 PST 2018


grimar created this revision.
grimar added a reviewer: ruiu.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.

This is https://bugs.llvm.org//show_bug.cgi?id=39418.

Currently, when LLD do ICF it checks if the output section name is the same,
but that works only for no linker script case.
We create output sections and assign input sections much later.
The patch adds logic to predict the output sections earlier, so that
we can ICF in a more correct way without complicated changes to linker design.


https://reviews.llvm.org/D54422

Files:
  ELF/ICF.cpp
  ELF/LinkerScript.cpp
  ELF/LinkerScript.h
  test/ELF/linkerscript/icf-output-section.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54422.173655.patch
Type: text/x-patch
Size: 4806 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181112/ec9b1b53/attachment.bin>


More information about the llvm-commits mailing list