[PATCH] D54223: [SimpleLoopUnswitch] adding cost multiplier to cap exponential unswitch with

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 12 03:39:53 PST 2018


fedor.sergeev added inline comments.


================
Comment at: lib/Transforms/Scalar/SimpleLoopUnswitch.cpp:75
 
+static cl::opt<bool> EnableUnswitchCostMultiplier(
+    "enable-unswitch-cost-multiplier", cl::init(true), cl::Hidden,
----------------
mkazantsev wrote:
> That name is not super-informative. Maybe something like `LimitUnswitchingFromExponentExplosion` or something of this variety?
There might be other means of controlling this explosion things.
I would prefer naming by actual semantics and not by the most interesting side-effect.
This is definitely not an option that anybody should use lightly.


Repository:
  rL LLVM

https://reviews.llvm.org/D54223





More information about the llvm-commits mailing list