[PATCH] D54415: [llvm-exegesis] InstructionBenchmarkClustering::rangeQuery(): reserve for the upper bound of Neighbors

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: tools/llvm-exegesis/lib/Clustering.cpp:140
   }
+  // assert(Neighbors.capacity() == (Points_.size() - 1));
+  // ^ True, but it is not quaranteed to be true in all the cases.
----------------
lebedev.ri wrote:
> MaskRay wrote:
> > I've lost in the patch series :( I think I understand the DBSCAN implementation well enough now. You may consider merging some revisions related to the vector optimization and commit them at once? They should be quite obvious.
> > 
> > I understand that reordering/rebasing several commits is painful... (I am also try avoiding `git rebase --onto readPubNamesAndTypes HEAD\^`)
> > I've lost in the patch series :(
> 
> It is quite easy to orient.
> Ctrl+F for "Revision Contents", then click on the "Stack (n open)" tab.
> They are all listed there, in their correct order, from bottom to top.
(replied too quickly)
> I understand that reordering/rebasing several commits is painful.
The rebasing itself is absolutely **not** painful for me. It's trivial.
The only problem is that it **will** force me to re-benchmark **every** single differential,
and will result in less of an atomic incremental changes
(while those changes do make sense on their own.)


Repository:
  rL LLVM

https://reviews.llvm.org/D54415