[PATCH] D54314: [ELF] - Fix R_AARCH64_ADR_GOT_PAGE, R_AARCH64_LD64_GOT_LO12 handling against IFUNC symbols.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 11 20:45:03 PST 2018


ruiu added inline comments.


================
Comment at: ELF/Relocations.h:38
   R_GOT,
+  R_GOT_PLT,
   R_GOTONLY_PC,
----------------
Please add comments to the entries you are adding in this patch. We have to add comments to all these enums. These constants are extremely important but has no description at all. As a starter, we shouldn't add new entries without comments.


https://reviews.llvm.org/D54314





More information about the llvm-commits mailing list