[PATCH] D54287: [WebAssembly] Implement TargetLowering hooks for vectors

[Dan Gohman via Phabricator via llvm-commits]

sunfish added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:513
+    EVT, unsigned DefinedValues) const {
+  // Shuffles are very large (18 bytes!), so we would rather not use them.
+  return false;
----------------
While shuffles are quite large, the alternative is to store each element to the stack, one at a time, and then load them back as a vector. This will often be larger than the corresponding shuffle sequence. And it'll very likely be slower.


Repository:
  rL LLVM

https://reviews.llvm.org/D54287