[PATCH] D54381: [llvm-exegesis] InstructionBenchmarkClustering::dbScan(): use llvm::SetVector<> instead of ILLEGAL std::unordered_set<>

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Not related to this patch series but some complaints about the existing interface (sorry)... I feel it is sort of over-engineered, e.g.

- `kError` (related to `InstructionBenchmark::Error`) is not used but it is defined as a special `ClusterId` value.
- `kNoise` `kUndef` can just be exposed as public members and no static member functions `noise()` `error()` are needed.
- `PerInstructionStats::min()`. It is defined as `numeric_limits<double>::min()` but never modified.


Repository:
  rL LLVM

https://reviews.llvm.org/D54381