[PATCH] D54390: [llvm-exegesis] InstructionBenchmarkClustering::rangeQuery(): write into llvm::SmallVectorImpl& output parameter

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 11 16:26:15 PST 2018


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LG. The issue is that there shouldn't be frequent `SmallVector` construction/destruction in the loop body.

Here comes my own question: when the specific vector type does not matter too much (as in this case), when shall we choose `SmallVector` and when `std::vector`?


Repository:
  rL LLVM

https://reviews.llvm.org/D54390





More information about the llvm-commits mailing list