[PATCH] D54398: [IPSCCP] Delete two forward declarations

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 11 13:49:33 PST 2018


MaskRay created this revision.
MaskRay added a reviewer: fhahn.
Herald added a subscriber: llvm-commits.

The build failure was concurrently fixed by https://reviews.llvm.org/rL346619. SCCP.h is only included by 3 .cpp files and all of them include PostDominators.h anyway. It does not seem very necessary to use forward declarations.


Repository:
  rL LLVM

https://reviews.llvm.org/D54398

Files:
  include/llvm/Transforms/Scalar/SCCP.h


Index: include/llvm/Transforms/Scalar/SCCP.h
===================================================================
--- include/llvm/Transforms/Scalar/SCCP.h
+++ include/llvm/Transforms/Scalar/SCCP.h
@@ -32,9 +32,6 @@
 
 namespace llvm {
 
-class Function;
-class PostDominatorTree;
-
 /// This pass performs function-level constant propagation and merging.
 class SCCPPass : public PassInfoMixin<SCCPPass> {
 public:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54398.173577.patch
Type: text/x-patch
Size: 415 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181111/5c9ab7eb/attachment.bin>


More information about the llvm-commits mailing list