[PATCH] D54396: [MS Demangler] Print public:, protected:, private: if set in FunctionClass.

[Nico Weber via Phabricator via llvm-commits]

thakis created this revision.
thakis added a reviewer: zturner.
Herald added a subscriber: erik.pilkington.
thakis added inline comments.


================
Comment at: lib/Demangle/MicrosoftDemangleNodes.cpp:386
+  if (FunctionClass & FC_ExternC)
+    OS << "extern \"C\" ";
+
----------------
(I'm reordering this to make the order in the function match the order of the FC_ enum entries.)


undname prints them, and the information is in the decorated name, so we probably shouldn't lose it when undecorating.

I spot-checked a few of the funnier-looking outputs, and undname has the same output.


https://reviews.llvm.org/D54396

Files:
  lib/Demangle/MicrosoftDemangleNodes.cpp
  test/Demangle/ms-cxx11.test
  test/Demangle/ms-cxx14.test
  test/Demangle/ms-nested-scopes.test
  test/Demangle/ms-operators.test
  test/Demangle/ms-template-callback.test
  test/Demangle/ms-templates-memptrs.test
  test/Demangle/ms-templates.test
  test/Demangle/ms-thunks.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54396.173570.patch
Type: text/x-patch
Size: 10879 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181111/7b3aef7e/attachment.bin>