[PATCH] D53444: Support ARM_V4BX relocation

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/ELF/v4bx.s:1
+// REQUIRES: arm
+// RUN: yaml2obj %p/Inputs/v4bx.yaml -o %tv4bx.o
----------------
yinma wrote:
> ruiu wrote:
> > ruiu wrote:
> > > I think you don't need two input files. This main test file can be written in YAML which contains `_start` symbol.
> > Hmm, do you still need this empty object file?
> I need lld to link an object containing a V4BX relocation.
I think @ruiu means: as you don't use `test/ELF/v4bx.s` to produce an object file. You could `mv test/ELF/Inputs/v4bx.yaml test/ELF/v4bx.yaml` and put check lines in `v4bx.yaml`. `v4bx.s` is not necessary.


https://reviews.llvm.org/D53444