[PATCH] D54378: Add Hurd triplet

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 10 08:54:16 PST 2018


rengolin added a comment.

In https://reviews.llvm.org/D54378#1294257, @sthibaul wrote:

> To be honest, I hadn't even imagined that the patch could have consequences on non-Hurd systems.


Me neither, that's why I was so optimistic. :/

>   “StartsWith("gnu", Triple::Hurd)”
>    
> 
> is really supposed to be the way to detect the GNU (aka GNU/Hurd) triplet (we usually have e.g. i386-unknown-gnu0.3)

There are some implicit assumptions about the environment on "non-4th" position, meaning the dashes don't guarantee much.

The main problem is not what's "right" and "wrong", but what will work with everything else and what won't.

As I explained before, GCC gets away with quirky triples by not relying on them much, which we can't do.


https://reviews.llvm.org/D54378





More information about the llvm-commits mailing list