[PATCH] D54378: Add Hurd triplet

[Kristina Brooks via Phabricator via llvm-commits]

kristina added a subscriber: chandlerc.
kristina added a comment.

You could use a different entry point for the driver similar to clang-cl or do what clang does on Darwin systems, that would avoid using this triple. What goes into `clang` driver is translated into an invocation of `clang -cc1` frontend, which is where the `-triple` option is passed through. If you mess with the driver or just build your own invocation, and translate your triple to something that makes more sense internally (ie. `i386-pc-mach-gnu`) you have more leeway. Here however you're starting the process of adding a new experimental target to LLVM and in general my advice on new targets is to get some form of blessing from @chandlerc since I'd prefer for him to quickly glance over this. That's not to say I'm against adding support for GNU Hurd, I'm moreso implying that regardless of what GNU Hurd guidelines say, if they may cause problems in LLVM ecosystem, especially as far as core targets (or rather platforms) go, you have to consider the large ecosystems that use Clang and LLVM and sometimes adapt to avoid causing issues downstream (for example with distro vendors with Glibc/GNU Linux being the core of main variations of server and desktop Linux distros).


https://reviews.llvm.org/D54378