[PATCH] D54378: Add Hurd triplet

[Renato Golin via Phabricator via llvm-commits]

rengolin requested changes to this revision.
rengolin added a comment.
This revision now requires changes to proceed.

In https://reviews.llvm.org/D54378#1294220, @kristina wrote:

> Yes but my concern comes from possible confusion with Glibc based Linux targets which are one of the "main" targets supported by LLVM. Either adding `hurd` or `mach` somewhere would be sufficient to disambiguate it from others, and yes I'm aware that they have a somewhat free format but they convey some sort of information, ie. with Linux targets `gnu` implies GNU/Glibc-based userland, so going by that convention one could easily assume that said triple simply implies GNU/Glibc/ELF userland. I think simply using `gnu` is too ambiguous, especially considering this is being added as an experimental target.


I agree with you completely, but as Samuel said, they can't change the triple (no one can, really).

GCC gets away with this because the triple is part of the build process and doesn't mean a lot, but LLVM relies heavily on it.

So we're really between accepting the patch or not supporting Hurd at all (which is not that big of a problem, I get it :).

I think the issues I'm seeing in the tests are related to the confusion you mention, so I'm retracting my approval until it can be proven correct (and everyone agrees).


https://reviews.llvm.org/D54378