[PATCH] D54369: [llvm-size][libobject] Add explicit "inTextSegment" methods similar to "isText" section methods to calculate size correctly.

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 9 18:11:29 PST 2018


echristo added a comment.

I think this is the right direction, couple comment:

- More detail in the comments for the *Segment methods. Maybe something elaborating about link/execution time or something else? Examples as well :)
- While it's fairly obvious it'll work, a couple of sections with the right flags but not named the standard thing would be good for the test. .text.unlikely and .data1 maybe?


Repository:
  rL LLVM

https://reviews.llvm.org/D54369





More information about the llvm-commits mailing list