[PATCH] D54363: Fix DragonFlyBSD build

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 9 16:44:27 PST 2018


krytarowski added inline comments.


================
Comment at: lib/Support/Unix/Path.inc:41
 #include <sys/attr.h>
+#elif __DragonFly__
+#include <sys/mount.h>
----------------
devnexen wrote:
> krytarowski wrote:
> > `#elif defined(__DragonFly__)`
> Not really necessary here, sys/param.h is included.
This doesn't matter. It's a better style (in my taste) to not evaluate random symbols in cpp. It's also following the case of `__APPLE__` above and it's consistent.


Repository:
  rL LLVM

https://reviews.llvm.org/D54363





More information about the llvm-commits mailing list