[PATCH] D54137: AArch64: Fix invalid CCMP emission

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added reviewers: t.p.northover, efriedma, greened, evandro, gberry.
MatzeB added a comment.

Maybe you can give it at least some cursory review?

Adding some more reviewers who were active in AArch64ISelLowering recently.

> Or is @MatzeB confident enough in the change as is?
>  Also, should we try to get this, together with the preceding refactoring, into 7.0.1?

I feel confident that this code is bettter than before. And I would also recommend pushing it for 7.0.1 (if we had it on the buildbots for a couple days) considering that it fixes a miscompile in "normal" code.



================
Comment at: test/CodeGen/AArch64/arm64-ccmp.ll:529
 ; CHECK-NEXT: fcmp d0, d1
-; CHECK-NEXT: fccmp d0, d1, #1, ne
-; CHECK-NEXT: fccmp d2, d3, #8, vs
+; CHECK-NEXT: fccmp d0, d1, #8, le
+; CHECK-NEXT: fccmp d2, d3, #8, pl
----------------
Note those changes here and in the next test are benign, the result is the same either way (I even tested this with a program that tries all possible combinations of float numbers generating different comparison results).


Repository:
  rL LLVM

https://reviews.llvm.org/D54137