[PATCH] D51524: [ARM64] [Windows] Handle funclets

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 9 14:25:37 PST 2018


efriedma added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:1681
+    BuildMI(MBB, FirstEpilogSEH, DL, TII->get(AArch64::ADRP))
+        .addReg(AArch64::X0, RegState::Define)
+        .addMBB(TargetMBB);
----------------
rnk wrote:
> Yep, makes sense, put the address of the target MBB in X0. Do you have any assurance that X0 isn't used by normal epilogue code? At least on x86, sometimes RAX gets used for large SP updates.
The current AArch64 emitFrameOffset never does that.  And even if it did in some cases, a funclet's stack can't be more than a few hundred bytes anyway.


Repository:
  rL LLVM

https://reviews.llvm.org/D51524





More information about the llvm-commits mailing list