[PATCH] D54353: [WebAssembly] Disable custom NaN payload tests

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 9 14:08:00 PST 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL346558: [WebAssembly] Disable custom NaN payload tests (authored by tlively, committed by ).

Repository:
  rL LLVM

https://reviews.llvm.org/D54353

Files:
  llvm/trunk/test/CodeGen/WebAssembly/immediates.ll


Index: llvm/trunk/test/CodeGen/WebAssembly/immediates.ll
===================================================================
--- llvm/trunk/test/CodeGen/WebAssembly/immediates.ll
+++ llvm/trunk/test/CodeGen/WebAssembly/immediates.ll
@@ -216,18 +216,22 @@
   ret double 0xFFF0000000000000
 }
 
-; CHECK-LABEL: custom_nan_f64:
-; CHECK-NEXT: .result f64{{$}}
-; CHECK-NEXT: f64.const $push[[NUM:[0-9]+]]=, -nan:0xabcdef0123456{{$}}
-; CHECK-NEXT: return $pop[[NUM]]{{$}}
-define double @custom_nan_f64() {
-  ret double 0xFFFABCDEF0123456
-}
-
-; CHECK-LABEL: custom_nans_f64:
-; CHECK-NEXT: .result f64{{$}}
-; CHECK-NEXT: f64.const $push[[NUM:[0-9]+]]=, -nan:0x2bcdef0123456{{$}}
-; CHECK-NEXT: return $pop[[NUM]]{{$}}
-define double @custom_nans_f64() {
-  ret double 0xFFF2BCDEF0123456
-}
+;; Custom NaN playloads are currently not always preserved because of the use of
+;; native doubles in the MC layer. TODO: fix this problem or decide we don't
+;; care about preserving NaN payloads.
+
+; XXX-CHECK-LABEL: custom_nan_f64:
+; XXX-CHECK-NEXT: .result f64{{$}}
+; XXX-CHECK-NEXT: f64.const $push[[NUM:[0-9]+]]=, -nan:0xabcdef0123456{{$}}
+; XXX-CHECK-NEXT: return $pop[[NUM]]{{$}}
+; define double @custom_nan_f64() {
+;   ret double 0xFFFABCDEF0123456
+; }
+
+; XXX-CHECK-LABEL: custom_nans_f64:
+; XXX-CHECK-NEXT: .result f64{{$}}
+; XXX-CHECK-NEXT: f64.const $push[[NUM:[0-9]+]]=, -nan:0x2bcdef0123456{{$}}
+; XXX-CHECK-NEXT: return $pop[[NUM]]{{$}}
+; define double @custom_nans_f64() {
+;   ret double 0xFFF2BCDEF0123456
+; }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54353.173439.patch
Type: text/x-patch
Size: 1535 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181109/ed923019/attachment.bin>


More information about the llvm-commits mailing list