[llvm] r346558 - [WebAssembly] Disable custom NaN payload tests

Thomas Lively via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 9 14:04:37 PST 2018


Author: tlively
Date: Fri Nov  9 14:04:37 2018
New Revision: 346558

URL: http://llvm.org/viewvc/llvm-project?rev=346558&view=rev
Log:
[WebAssembly] Disable custom NaN payload tests

Summary:
These tests fail on 32-bit builds because NaN payload bits in floating point
immediates are not necessarily preserved through compilation. This is because
the MC layer uses native doubles to store these values. The tests will be
reenabled once this problem has been fixed or deleted if we decide we don't care
about lowering payload bits.

Reviewers: aheejin, dschuff

Subscribers: sbc100, jgravelle-google, sunfish, llvm-commits

Differential Revision: https://reviews.llvm.org/D54353

Modified:
    llvm/trunk/test/CodeGen/WebAssembly/immediates.ll

Modified: llvm/trunk/test/CodeGen/WebAssembly/immediates.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/WebAssembly/immediates.ll?rev=346558&r1=346557&r2=346558&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/WebAssembly/immediates.ll (original)
+++ llvm/trunk/test/CodeGen/WebAssembly/immediates.ll Fri Nov  9 14:04:37 2018
@@ -216,18 +216,22 @@ define double @neginf_f64() {
   ret double 0xFFF0000000000000
 }
 
-; CHECK-LABEL: custom_nan_f64:
-; CHECK-NEXT: .result f64{{$}}
-; CHECK-NEXT: f64.const $push[[NUM:[0-9]+]]=, -nan:0xabcdef0123456{{$}}
-; CHECK-NEXT: return $pop[[NUM]]{{$}}
-define double @custom_nan_f64() {
-  ret double 0xFFFABCDEF0123456
-}
+;; Custom NaN playloads are currently not always preserved because of the use of
+;; native doubles in the MC layer. TODO: fix this problem or decide we don't
+;; care about preserving NaN payloads.
 
-; CHECK-LABEL: custom_nans_f64:
-; CHECK-NEXT: .result f64{{$}}
-; CHECK-NEXT: f64.const $push[[NUM:[0-9]+]]=, -nan:0x2bcdef0123456{{$}}
-; CHECK-NEXT: return $pop[[NUM]]{{$}}
-define double @custom_nans_f64() {
-  ret double 0xFFF2BCDEF0123456
-}
+; XXX-CHECK-LABEL: custom_nan_f64:
+; XXX-CHECK-NEXT: .result f64{{$}}
+; XXX-CHECK-NEXT: f64.const $push[[NUM:[0-9]+]]=, -nan:0xabcdef0123456{{$}}
+; XXX-CHECK-NEXT: return $pop[[NUM]]{{$}}
+; define double @custom_nan_f64() {
+;   ret double 0xFFFABCDEF0123456
+; }
+
+; XXX-CHECK-LABEL: custom_nans_f64:
+; XXX-CHECK-NEXT: .result f64{{$}}
+; XXX-CHECK-NEXT: f64.const $push[[NUM:[0-9]+]]=, -nan:0x2bcdef0123456{{$}}
+; XXX-CHECK-NEXT: return $pop[[NUM]]{{$}}
+; define double @custom_nans_f64() {
+;   ret double 0xFFF2BCDEF0123456
+; }




More information about the llvm-commits mailing list