[PATCH] D54284: [hwasan] Add entire report to abort message on Android.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added inline comments.


================
Comment at: compiler-rt/lib/hwasan/hwasan_report.cc:68
+
+InternalMmapVector<char> *ScopedReport::error_message_ptr_;
+BlockingMutex ScopedReport::error_message_lock_;
----------------
eugenis wrote:
> kcc wrote:
> > why not InternalScopedString ? 
> I don't like InternalScopedString. Its append method truncates the string instead of resizing the storage, and also does unnecessary format string parsing.
> 
ack. 
I'd prefer to add append() method to InternalMmapVector then and use it here


https://reviews.llvm.org/D54284