[PATCH] D53710: [FileCheck] Warn if a prefix is only used in LABEL checks

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In https://reviews.llvm.org/D53710#1293198, @probinson wrote:

> I hadn't thought about `-v`; I don't think the new diag is currently under `-v`? The first test isn't using that option...
>
> I think we should encourage people to have warnings on when they develop their tests.  Having that separate from `-v` seems like a good thing, as `-v` obviously dumps a lot of info, most of which would ordinarily describe a test behaving exactly as intended.


I believe you're thinking of FileCheck's -v.  Sjoerd was describing lit's -v.

>   A `-warn` option to turn everything on/off (default off) should be sufficient, at least for now when the number of different warnings is pretty small.  More fine-grained `-W` options seems like overkill.

OK.  I was imagining that building that infrastructure now would encourage more warning explorations in the future, and that could benefit FileCheck.  But we can always wait to see if people come up with more warnings.


https://reviews.llvm.org/D53710