[PATCH] D54312: [CSP, Cloning] Update DuplicateInstructionsInSplitBetween to use DomTreeUpdater.

[Jun Bum Lim via Phabricator via llvm-commits]

junbuml added inline comments.


================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:443
+
+static PredsWithCondsTy tryToSplitOnPHIPredicatedArgument(CallSite CS) {
   if (!isPredicatedOnPHI(CS))
----------------
Now this function collects PredsWithCondsTy without performing splitting. Can you change this function name accordingly. 


================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:499-503
+  auto PredsWithConds = tryToSplitOnPredicatedArgument(CS, DTU);
+  if (PredsWithConds.empty())
+    PredsWithConds = tryToSplitOnPHIPredicatedArgument(CS);
+  if (PredsWithConds.empty())
+    return false;
----------------
What about doing this in a separate function ?


https://reviews.llvm.org/D54312