[PATCH] D54314: [ELF] - Fix R_AARCH64_ADR_GOT_PAGE, R_AARCH64_LD64_GOT_LO12 handling against IFUNC symbols.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D54314#1293000, @peter.smith wrote:

> I wasn't sure if this was to be applied on top of https://reviews.llvm.org/D54154 or not so I merged the two and ended up with a test failure in  the test modifications done in ELF/gotpc-relax.s for https://reviews.llvm.org/D54154.
>
>   llvm/tools/lld/test/ELF/gotpc-relax.s:27:16: error: DISASM-NEXT: expected string not found in input
>   # DISASM-NEXT: 20101f: {{.*}} movq 8154(%rip), %rax
>                  ^
>   <stdin>:19:2: note: scanning from here
>    20101f: 48 8b 05 da 0f 00 00 movq 4058(%rip), %rax
>    ^
>   <stdin>:19:25: note: possible intended match here
>    20101f: 48 8b 05 da 0f 00 00 movq 4058(%rip), %rax
>  
>
>
> It will be worth double checking to see if this hasn't broken x86? Or am I missing something?


I assumed this should be independent change, so I did not test them together. I'll try to merge them and check the case you are observing. Thanks!


https://reviews.llvm.org/D54314