[PATCH] D54244: [HotColdSplitting] Refine definition of unlikelyExecuted

[Jun Bum Lim via Phabricator via llvm-commits]

junbuml added a comment.

Thanks Vedant for handling this. Overall I agree with this change, but I believe it's good to break this patch down into three parts and get each of them reviewed separately :

1. Mark @llvm.trap cold.
2. Do not treat noreturn calls as cold unless they are actually marked cold.
3. Do not treat inline asm as an outlining barrier.

Or

1. Mark @llvm.trap cold.
2. Do not treat noreturn calls as cold unless they are actually marked cold, and Do not treat inline asm as an outlining barrier.




https://reviews.llvm.org/D54244