[PATCH] D49362: [ThinLTO] Internalize read only globals

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 9 07:21:58 PST 2018


tejohnson added a comment.

In https://reviews.llvm.org/D49362#1292863, @evgeny777 wrote:

> > Why won't it work for distributed builds? The read only gvar flag is being serialized out and back in, so shouldn't it show up in the distributed indexes?
>
> It does, but we can't be sure about "read-only" unless we analyze function references. And we need propagateConstants for that.


propagateConstants should run during the thin link, which would happen in a distributed build before writing indexes. Maybe there is something weird about that test where it's not actually running the real thin link, will look...


https://reviews.llvm.org/D49362





More information about the llvm-commits mailing list