[PATCH] D54164: [AMDGPU] Optimize S_CBRANCH_VCC[N]Z -> S_CBRANCH_EXEC[N]Z

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

Two stylistic nitpicks. LGTM with those addressed.



================
Comment at: lib/Target/AMDGPU/SIInsertSkips.cpp:69
 
+  bool OptimizeVccBranch(MachineInstr &MI) const;
+
----------------
Function names should be lowerCamelCase.


================
Comment at: lib/Target/AMDGPU/SIInsertSkips.cpp:338-339
+
+  MachineBasicBlock::reverse_iterator A = MI.getReverseIterator(),
+                                      B = MBB.rend();
+  bool ReadsCond = false;
----------------
Rename B to E please, that's more idiomatic.


https://reviews.llvm.org/D54164