[PATCH] D54226: AMDGPU/InsertWaitcnts: Untangle some semi-global state

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 9 07:14:20 PST 2018


nhaehnle updated this revision to Diff 173327.
nhaehnle added a comment.

Turns out I was a bit too quick in my analysis of the second point.
I thought the overly conservative waitcnt was due to the control flow
in the shader I was looking at, but it was actually due to a pre-existing
waitcnt.


Repository:
  rL LLVM

https://reviews.llvm.org/D54226

Files:
  lib/Target/AMDGPU/SIInsertWaitcnts.cpp
  lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
  lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
  test/CodeGen/AMDGPU/smrd-vccz-bug.ll
  test/CodeGen/AMDGPU/vccz-corrupt-bug-workaround.mir
  test/CodeGen/AMDGPU/waitcnt-preexisting.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54226.173327.patch
Type: text/x-patch
Size: 29137 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181109/0bd1c54e/attachment.bin>


More information about the llvm-commits mailing list