[PATCH] D49362: [ThinLTO] Internalize read only globals

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 9 06:03:28 PST 2018


evgeny777 marked 2 inline comments as done.
evgeny777 added a comment.

Sorry I have to suggest small amendment to this patch before committing after looking `test/ThinLTO/X86/distributed_import.ll`.
It looks like distributed import is using per-module indexes, so internalization of RO vars will not work correctly. To overcome this
I suggest adding a check for propagateConstants to have been run before marking GV for internalization

See https://reviews.llvm.org/D54306

This check is a bit counter intuitive, so suggestions welcome.


https://reviews.llvm.org/D49362





More information about the llvm-commits mailing list