[PATCH] D53554: [Argument Promotion] Only promote args when function attributes are compatible

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 8 19:12:35 PST 2018


echristo added inline comments.


================
Comment at: lib/Transforms/IPO/ArgumentPromotion.cpp:813
+/// Test that there are no attribute conflicts between Caller and Callee
+static bool functionsHaveCompatibleAttributes(const CallSite &CS,
+                                              const TargetTransformInfo &TTI) {
----------------
Seems like we should expose this on TTI and that way backends can override and keep a single copy between here and InlineCost.cpp.


Repository:
  rL LLVM

https://reviews.llvm.org/D53554





More information about the llvm-commits mailing list