[PATCH] D54279: wasm32: Respect `--no-mangle` in more locations in LLD

[Alex Crichton via Phabricator via llvm-commits]

alexcrichton added a comment.

Er oops sorry haven't submitted too many patches before so was just using `git diff`, but I've tried an update with `git diff -U100000` and that should have more context!



================
Comment at: wasm/Writer.cpp:568
-        Optional<std::string> Name = demangleItanium(F->getName());
-        writeStr(Sub.OS, Name ? StringRef(*Name) : F->getName(), "symbol name");
       }
----------------
sbc100 wrote:
> I think the idea was that the debug section should always contain de-mangled names and that --no-demangle was for the error message and what not.  I don't feel strongly about this though.    Do you even want mangled names in the names section?
Oh that makes sense! Our use case is that the Rust demangling scheme is itanium-like but not exactly. When run through the itanium demangler Rust symbols look reasonable, but they look much better when run through a Rust-specific demangler.



https://reviews.llvm.org/D54279