[PATCH] D54279: wasm32: Respect `--no-mangle` in more locations in LLD

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

Hmm, I don't see the context for this diff.. do you know about using 'arc diff' to upload?   Maybe its not worth your while to setup in which case no worries.



================
Comment at: wasm/Writer.cpp:568
-        Optional<std::string> Name = demangleItanium(F->getName());
-        writeStr(Sub.OS, Name ? StringRef(*Name) : F->getName(), "symbol name");
       }
----------------
I think the idea was that the debug section should always contain de-mangled names and that --no-demangle was for the error message and what not.  I don't feel strongly about this though.    Do you even want mangled names in the names section?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54279