[PATCH] D54266: [llvm-cov] Add lcov tracefile export format.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 8 12:58:03 PST 2018


vsk added inline comments.


================
Comment at: tools/llvm-cov/CodeCoverage.cpp:1015
+  if (ViewOpts.Format != CoverageViewOptions::OutputFormat::Text &&
+      ViewOpts.Format != CoverageViewOptions::OutputFormat::Lcov) {
+    error("Coverage data can only be exported as textual JSON or an "
----------------
Dor1s wrote:
> Just wondering whether we should add `json` format as well and document it instead of the `text`. Maybe eventually we'll be able to remove `text` at all to avoid any confusion? @vsk , what do you think?
This sounds like a good follow-up. In retrospect picking the name ‘text’ wasn’t a good idea, it’s a bit ambiguous.


Repository:
  rL LLVM

https://reviews.llvm.org/D54266





More information about the llvm-commits mailing list