[PATCH] D48179: [AMDGPU] Emit MessagePack HSA Metadata for v3 code object

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 8 12:43:06 PST 2018


kzhuravl requested changes to this revision.
kzhuravl added a comment.
This revision now requires changes to proceed.

Can you also rebase your change? I have done some changes to your patch in `amd-common` that you need to incorporate here.



================
Comment at: tools/llvm-readobj/ELFDumper.cpp:3775-3796
+  OS << "    AMDGPU Metadata:\n";
+  auto MsgPackString =
+      StringRef(reinterpret_cast<const char *>(Words.data()), Size);
+  msgpack::Reader MsgPackReader(MsgPackString);
+  auto OptMsgPackNodeOrErr = msgpack::Node::read(MsgPackReader);
+  if (auto Err = OptMsgPackNodeOrErr.takeError())
+    return error(std::move(Err));
----------------
Switch on a `NoteType`, then if the `NoteType` is `ELF::NT_AMDGPU_METADATA` interpret it.


https://reviews.llvm.org/D48179





More information about the llvm-commits mailing list