[PATCH] D53758: Handle value uses wrapped in metadata for the use-list order

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 8 10:41:57 PST 2018


dexonsmith added inline comments.


================
Comment at: test/Assembler/metadata-use-uselistorder.ll:5-6
+
+; Verify that the uses of i64 0 in the llvm.dbg.value operands are considered
+; when generating the use-list order.
+
----------------
Does this only cause problems for constants (like `i64 0`), or also for use lists of locals and globals?

The reason I ask: we *should* make it impossible for most constants to rely on use-list order, and then stop storing use-lists for them (in either bitcode or textual IR).  When we get there, should we delete this test and the new code you've added?  Or will it still be relevant for other values?


https://reviews.llvm.org/D53758





More information about the llvm-commits mailing list