[PATCH] D49491: [RFC][VPlan, SLP] Add simple SLP analysis on top of VPlan.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 8 09:04:45 PST 2018


fhahn updated this revision to Diff 173176.
fhahn marked an inline comment as done.
fhahn added a subscriber: sguggill.
fhahn added a comment.

In https://reviews.llvm.org/D49491#1291680, @ABataev wrote:

> Just one more question: how do you estimate that the vectorized code is more effective than the scalar one? What's the criterion?


This patch as a first step only adds support for the transform without cost modelling. This transform is intended as a VPlan2VPlan transformation and the general idea is to create multiple VPlans (say one with all the SLP opportunities applied and one with none) and evaluate the cost of the resulting VPlans at the end to choose the best one.

Together with @sguggill , we gave a brief overview of VP2VP transforms at the dev meeting (http://llvm.org/devmtg/2018-10/talk-abstracts.html#talk21) and this is something I want to write up a bit better in the actual VPlan design documentation.


https://reviews.llvm.org/D49491

Files:
  lib/Transforms/Vectorize/CMakeLists.txt
  lib/Transforms/Vectorize/VPlan.cpp
  lib/Transforms/Vectorize/VPlan.h
  lib/Transforms/Vectorize/VPlanSLP.cpp
  lib/Transforms/Vectorize/VPlanValue.h
  unittests/Transforms/Vectorize/CMakeLists.txt
  unittests/Transforms/Vectorize/VPlanSlpTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49491.173176.patch
Type: text/x-patch
Size: 66820 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181108/9467ce7c/attachment-0001.bin>


More information about the llvm-commits mailing list