[PATCH] D47259: [IPSCCP,PM] Preserve DT in the new pass manager.

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 8 07:21:40 PST 2018


kuhar added a reviewer: NutshellySima.
kuhar added inline comments.


================
Comment at: lib/Transforms/Scalar/SCCP.cpp:2002
 
+    SmallVector<BasicBlock *, 512> BlocksToErase;
+
----------------
Does it make sense to have a SmallVector of such size here? I can see that this code wasn't introduce in this patch, but wanted to note it anyway.


================
Comment at: lib/Transforms/Scalar/SCCP.cpp:2052
+        NumInstRemoved += changeToUnreachable(F.front().getFirstNonPHI(),
+                                              /*UseLLVMTrap=*/false);
+    } else {
----------------
Why is DTU passed to this function in a few of lines above but not here?


https://reviews.llvm.org/D47259





More information about the llvm-commits mailing list