[PATCH] D54145: [ELF] - Fix R_X86_64_GOTPCRELX/R_X86_64_REX_GOTPCRELX when target is IFUNC.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D54145#1291565, @peter.smith wrote:

> In my example I was using -fpic , without it then we get a different relocation type R_AARCH64_ADR_PREL_PG_HI21 (with -fpic it is R_AARCH64_ADR_GOT_PAGE), I suspect that is why I didn't see the IRELATIVE relocation. I don't mind if we keep this patch to be specific to non-AArch64, but if we do the we either shouldn't close the PR until we've made it work, or raise another PR to make sure we don't forget about it.


Ah, my mistake, sorry. I did not use -fPIC because of wrong assumption (it did not segfault with fPIC and I started to try to catch the crash, though it seems to be a different issue).
So, you right, with -fPIC I do not see the relocation and was able to reproduce the issue mentioned in description finally. 
I'll try to fix it then.

(and sure we should not close the PR without a fix for AArch64.)


https://reviews.llvm.org/D54145